Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Dave Rolsky <autarch(at)urth(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist
Date: 2013-02-16 17:47:31
Message-ID: CAFj8pRBihcCEK-bcQEgCqLdLjQQ+J5PUyeZTekXHi_hoaEkoBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

2013/2/16 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> On Fri, Feb 15, 2013 at 04:06:12PM -0600, Dave Rolsky wrote:
>>> Fair enough. It should probably an option to add "if exists", at
>>> least. I can't imagine I'm the only using this tool to ship database
>>> updates around to different machines, some of which may not have new
>>> tables. I'd really like to be able to know when the restore fails
>>> versus when it succeeds but is noisy.
>
>> All I can say is I don't remember anyone asking for this in the past.
>
> I think it has come up before. I wouldn't object to a pg_dump option to
> add IF EXISTS to all the drop commands (though changing the default
> behavior would be more controversial). Don't intend to spend my own
> time on it though ...

we use this feature more than one year.

I'll send patch at Monday

Regards

Pavel Stehule

>
> regards, tom lane
>
>
> --
> Sent via pgsql-bugs mailing list (pgsql-bugs(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-bugs

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Maciek Sakrejda 2013-02-16 22:31:57 Re: BUG #7883: "PANIC: WAL contains references to invalid pages" on replica recovery
Previous Message Tom Lane 2013-02-16 16:35:01 Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-02-16 17:53:14 Re: Materialized views WIP patch
Previous Message Andres Freund 2013-02-16 17:22:10 Re: [RFC] indirect toast tuple support