From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Euler Taveira <euler(at)timbira(dot)com(dot)br>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: obsolete example |
Date: | 2019-11-22 05:11:32 |
Message-ID: | CAFj8pRBcxGvCNQFMZ9kBvznkdK-pCCc45wW=iP+g0A9_yn6U2g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
pá 22. 11. 2019 v 1:13 odesílatel Michael Paquier <michael(at)paquier(dot)xyz>
napsal:
> On Thu, Nov 21, 2019 at 08:19:56PM -0300, Euler Taveira wrote:
> > Em qui., 21 de nov. de 2019 às 15:59, Pavel Stehule
> > <pavel(dot)stehule(at)gmail(dot)com> escreveu:
> >>
> >> isn't src/tutorial/func.c obsolete? There is not any benefit for users.
> >
> > version-0 calling conventions were removed in v10. It seems an
> > oversight at commit 5ded4bd2140. Tutorial needs some care (I'm not
> > volunteering to improve it). I suggest unbreak the funcs module with
> > 'mv funcs_new.c func.c'.
>
> No objections from here, let's get rid of it. The docs actually make
> use of the V1 versions, and funcs_new.c is not even compiled (it does
> compile). Any objections to the attached? On top of moving the file,
> there is one comment to update and a sentence to remove. Some
> progress is always better than no progress.
>
+1
Pavel
> --
> Michael
>
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2019-11-22 05:15:25 | Re: Why overhead of SPI is so large? |
Previous Message | Kyotaro Horiguchi | 2019-11-22 04:47:39 | Re: an OID >= 8000 in master |