Re: review: CHECK FUNCTION statement

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: CHECK FUNCTION statement
Date: 2012-03-06 14:12:57
Message-ID: CAFj8pRBb1AhE--eePJs2ipkw9s3-FN5Cf0OCKhw+TobupKTaMA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2012/3/6 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
>
> Excerpts from Pavel Stehule's message of mar mar 06 10:44:09 -0300 2012:
>>
>> 2012/3/6 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
>> >
>> > Excerpts from Pavel Stehule's message of mar mar 06 03:43:06 -0300 2012:
>> >> Hello
>> >>
>> >> * I refreshed regress tests and appended tests for multi lines query
>> >> * There are enhanced checking of SELECT INTO statement
>> >> * I fixed showing details and hints
>> >
>> > Oh, I forgot to remove the do_tup_output_slot() function which I added
>> > in some previous version but is no longer necessary.  Also, there are
>> > two includes that I put separately in functioncmds.c that are only
>> > necessary for the CHECK FUNCTION stuff; those should be merged in with
>> > the other includes there.  (I was toying with the idea of moving all
>> > that code to a new file).
>> >
>>
>> I am not sure, what you did do. Can you remove this useless code, please?
>
> It's just a three line function that's not called anywhere.

ok

fixed patch

Pavel

>
> --
> Álvaro Herrera <alvherre(at)commandprompt(dot)com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment Content-Type Size
check_function-2012-03-06-2.patch.gz application/x-gzip 33.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2012-03-06 14:14:54 Re: [v9.2] Add GUC sepgsql.client_label
Previous Message Robert Haas 2012-03-06 13:36:05 Re: RFC: Making TRUNCATE more "MVCC-safe"