| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bugfix: BUG #15477: Procedure call with named inout refcursor parameter - "invalid input syntax for type boolean" |
| Date: | 2018-11-04 16:23:11 |
| Message-ID: | CAFj8pRBYRFqr_ZW+aUnX9MVDme3yBRPGNa0MM=6RR6NV=y2dgg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
ne 4. 11. 2018 v 17:14 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > ne 4. 11. 2018 v 16:54 odesilatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
> >> In short, I think it's a bug that we allow the above. If you
> >> want to keep the must-be-a-variable error then it should apply in
> >> this case too.
>
> > I agree. This should be prohibited from PLpgSQL.
>
> OK. In that case I'll run with my patch. The attached is what I had
> code-wise, but I've not changed the regression tests to match ... gotta
> go fix the docs too I guess.
>
I am not sure how safe is read argmodes from syscache after procedure
execution. Theoretically, the procedure pg_proc tuple can be modified from
procedure, and can be committed from procedure. Isn't better to safe
argmodes before execution?
regards
Pavel
>
> regards, tom lane
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-04 16:59:27 | Re: bugfix: BUG #15477: Procedure call with named inout refcursor parameter - "invalid input syntax for type boolean" |
| Previous Message | Andrey Lepikhov | 2018-11-04 16:21:08 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |