Re: patch: make_timestamp function

Hello

2013/12/13 Jim Nasby <jim(at)nasby(dot)net>

> On 12/13/13 1:49 PM, Fabrízio de Royes Mello wrote:
>
>>
>> On Fri, Dec 13, 2013 at 5:35 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us <mailto:
>> tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>>
>> >
>> > =?ISO-8859-1?Q?Fabr=EDzio_de_Royes_Mello?= <fabriziomello(at)gmail(dot)com<mailto:
>> fabriziomello(at)gmail(dot)com>> writes:
>> > > I think the goal of the "make_date/time/timestamp" function series
>> is build
>> > > a date/time/timestamp from scratch, so the use of 'make_timestamptz'
>> is to
>> > > build a specific timestamp with timezone and don't convert it.
>> >
>> > Yeah; we don't really want to incur an extra timezone rotation just to
>> get
>> > to a timestamptz. However, it's not clear to me if make_timestamptz()
>> > needs to have an explicit zone parameter or not. It could just assume
>> > that you meant the active timezone.
>> >
>>
>> +1. And if you want a different timezone you can just set the 'timezone'
>> GUC.
>>
>
> Why wouldn't we have a version that optionally accepts the timezone? That
> mirrors what you can currently do with a cast from text, and having to set
> the GUC if you need a different TZ would be a real PITA.
>

It is not bad idea.

What will be format for timezone in this case? Is a doble enough?

last version of this patch attached (without overloading in this moment)

> --
> Jim C. Nasby, Data Architect jim(at)nasby(dot)net
> 512.569.9461 (cell) http://jim.nasby.net
>