Re: orafce: some of the build time generated files are not present in .gitignore and also checked into the repository

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: orafce: some of the build time generated files are not present in .gitignore and also checked into the repository
Date: 2022-04-26 16:42:16
Message-ID: CAFj8pRBP-aZ8uM=TnmSF_L1DYocSVPNZM3fnkuLnnZgV84TQcQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

út 26. 4. 2022 v 18:36 odesílatel Bruce Momjian <bruce(at)momjian(dot)us> napsal:

> On Tue, Apr 26, 2022 at 06:17:41PM +0200, Pavel Stehule wrote:
> >
> > út 26. 4. 2022 v 14:19 odesílatel Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com
> >
> > napsal:
> >
> > Hi,
> >
> > The below files in orafce contrib module are generated at build time.
> > However, these are checked into the repository. Shouldn't these files
> > be removed from the repository and added to the .gitignore file so
> > that they get ignored in the future commits.
> >
> > sqlparse.c
> > sqlscan.c
> > sqlparse.h
> >
> > Without these files there is a problem with MSVC build.
>
> Uh, I am kind of lost here. Why was this reported to the Postgres
> server email lists and not to the orafce email lists? Is there
> confusion who develops/support orafce? Which MSVC build is broken? The
> Postgres server or orafce?
>

I am sorry. This is just Orafce topic.

Regards

Pavel

>
> I assume the problem is that the 'makefile' system generates these
> files, but the MSVC build doesn't generate them, so it is just easier to
> check them in after a make build so MSVC can use them, and another make
> run will just overwrite them.
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
> EDB https://enterprisedb.com
>
> Indecision is a decision. Inaction is an action. Mark Batterson
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Wong 2022-04-26 17:36:17 Re: DBT-5 Stored Procedure Development (2022)
Previous Message Bruce Momjian 2022-04-26 16:36:44 Re: orafce: some of the build time generated files are not present in .gitignore and also checked into the repository