Re: XMLDocument (SQL/XML X030)

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Chapman Flack <jcflack(at)acm(dot)org>, Robert Treat <rob(at)xzilla(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: XMLDocument (SQL/XML X030)
Date: 2025-01-25 10:50:52
Message-ID: CAFj8pRBMCx+WNg0Pfq_+zTwq2DSW55fkJpttcKCnAr--fZt3Vg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

so 25. 1. 2025 v 9:10 odesílatel Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
napsal:

>
> On 25.01.25 08:16, Pavel Stehule wrote:
> > because the function does nothing, then it is useless to convert input
> > to XML and force detosting
>
> Right. Fixed in v7 attached.
>

I don't see

+Datum
+xmldocument(PG_FUNCTION_ARGS)
+{
+#ifdef USE_LIBXML
+ PG_RETURN_XML_P(PG_GETARG_XML_P(0));
+#else
+ NO_XML_SUPPORT();
+ return 0;
+#endif /* not USE_LIBXML */
+}
+

you still forces detoasting (inside PG_GETARG_XML_P)

>
> Thanks
>
> Best, Jim
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robins Tharakan 2025-01-25 11:18:13 Re: Convert sepgsql tests to TAP
Previous Message Álvaro Herrera 2025-01-25 10:29:13 Re: Allow NOT VALID foreign key constraints on partitioned tables.