Re: Fwd: patch: make_timestamp function

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomáš Vondra <tv(at)fuzzy(dot)cz>
Subject: Re: Fwd: patch: make_timestamp function
Date: 2014-03-05 15:08:28
Message-ID: CAFj8pRBA0TBEaD_Fo9649Wd1HU9J_ijFU9h-8J5v=WUkqnX7Dw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

I hope, so this patch fix it

Regards

Pavel

2014-03-04 21:00 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:

>
>
>
> 2014-03-04 20:20 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
>
> Pavel Stehule escribió:
>> > 2014-03-04 19:12 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
>> >
>> > > Pavel Stehule escribió:
>> > > > Hello
>> > > >
>> > > > updated version - a precheck is very simple, and I what I tested it
>> is
>> > > > enough
>> > >
>> > > Okay, thanks. I pushed it after some more editorialization. I don't
>> > > think I broke anything, but please have a look.
>> >
>> > It looks well
>>
>> Coypu is showing a strange failure though:
>>
>>
>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=coypu&dt=2014-03-04%2018%3A22%3A31
>> select make_interval(secs := 'inf');
>> ! make_interval
>> ! ---------------------
>> ! @ 0.000001 secs ago
>> ! (1 row)
>>
>> I realize that we have some hacks in float4in and float8in to deal with
>> these portability issues ... Maybe the fix is just take out the test.
>>
>>
> I have no idea, how to fix it now and have to leave a office. Tomorrow
> I'll try to fix it.
>
> Regards
>
> Pavel
>
>
>
>> --
>> Álvaro Herrera http://www.2ndQuadrant.com/
>> PostgreSQL Development, 24x7 Support, Training & Services
>>
>
>

Attachment Content-Type Size
fix.patch text/x-patch 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-03-05 15:09:48 Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode
Previous Message Michael Paquier 2014-03-05 15:03:33 Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode