| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
| Subject: | Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan |
| Date: | 2018-01-23 14:50:40 |
| Message-ID: | CAFj8pRAtggi_=nFrXrfrr6xutn0QKvqJ88Uu6cFgDK9bDHmE3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2018-01-23 15:35 GMT+01:00 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Mon, Jan 22, 2018 at 5:15 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > Pavel,
> >
> > * Pavel Stehule (pavel(dot)stehule(at)gmail(dot)com) wrote:
> >> here is a GUC based patch for plancache controlling. Looks so this code
> is
> >> working.
> >
> > This really could use a new thread, imv. This thread is a year old and
> > about a completely different feature than what you've implemented here.
>
> + if (plancache_mode & PLANCACHE_FORCE_GENERIC_PLAN)
> + return false;
> + if (plancache_mode & PLANCACHE_FORCE_CUSTOM_PLAN)
> + return true;
>
> This should be ==, not &.
>
> I could explain why & happens to work, but I won't.
>
you have true, thank you
Pavel
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-01-23 14:52:39 | Re: [HACKERS] Deadlock in XLogInsert at AIX |
| Previous Message | Tom Lane | 2018-01-23 14:46:32 | Re: pg_upgrade tests failing on current master |