From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: custom function for converting human readable sizes to bytes |
Date: | 2015-12-20 09:54:30 |
Message-ID: | CAFj8pRAcJ+4xoxkRyZJNJ7dPbwtb42EPaogPH5BfZWoxx44Ysg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
new update:
1. unit searching is case insensitive
2. initial support for binary byte prefixes - KiB, MiB, .. (IEC standard),
change behave for SI units
Second point is much more complex then it is looking - if pg_size_bytes
should be consistent with pg_size_pretty.
The current pg_size_pretty and transformations in guc.c are based on JEDEC
standard. Using this standard for GUC has sense - using it for object sizes
is probably unhappy.
I tried to fix (and enhance) pg_size_pretty - now reports correct units,
and via second parameter it allows to specify base: 2 (binary, IEC -
default) or 10 (SI).
I think it is good to have it. These standards are generic and wide used,
but should to be pretty explained in documentation if we will use JEDEC for
configuration. Probably better to leave JEDEC and prefer SI and IEC.
Plan B is fix Postgres on JEDEC only - it is trivial, simple - but it can
look like archaic in next years.
Comments, notices?
Regards
Pavel
Attachment | Content-Type | Size |
---|---|---|
pg-size-bytes-03.patch | text/x-patch | 30.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-12-20 13:14:01 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
Previous Message | David Rowley | 2015-12-20 09:27:35 | Re: [PATCH] Equivalence Class Filters |