From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch: function xmltable |
Date: | 2016-09-23 20:22:02 |
Message-ID: | CAFj8pRAbLOLBUA--8zEBdDTCgV=GW5A080YCceDJwkxrKo0thA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
2016-09-23 10:07 GMT+02:00 Craig Ringer <craig(at)2ndquadrant(dot)com>:
> > Did some docs copy-editing and integrated some examples.
>
> Whoops, forgot to attach.
>
> Rather than sending a whole new copy of the patch, here's a diff
> against your patched tree of my changes so you can see what I've done
> and apply the parts you want.
>
> Note that I didn't updated the expected files.
>
I applied your patch - there is small misunderstanding. The PATH is
evaluated once for input row already. It is not clean in code, because it
is executor node started and running for all rows. I changed it in your
part of doc.
to a simple value before calling the function. <literal>PATH</>
+ expressions are normally evaluated <emphasis>exactly once per result
row ## per input row
+ </emphasis>,
Regards
Pavel
>
> --
> Craig Ringer http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-09-23 20:31:55 | PG 9.6.0 release schedule |
Previous Message | Andres Freund | 2016-09-23 20:17:19 | Re: Hash Indexes |