From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: unaccent module - two params function should be immutable |
Date: | 2013-09-14 13:42:32 |
Message-ID: | CAFj8pRAXf0UteRd8xLY8PRHuCUKkYttUEKkJ7rbgGLR72ntFBw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2013/9/11 Bruce Momjian <bruce(at)momjian(dot)us>
> On Tue, Feb 19, 2013 at 08:30:29AM +0100, Pavel Stehule wrote:
> > Hello
> >
> > There was a proposal to change flag of function to immutable - should
> > be used in indexes
> >
> > CREATE FUNCTION unaccent(regdictionary, text)
> > RETURNS text
> > AS 'MODULE_PATHNAME', 'unaccent_dict'
> > LANGUAGE C STABLE STRICT;
> >
> >
> > is there any progress?
>
> I have developed the attached patch based on your suggestion. I did not
> see anything in the code that would make it STABLE, except a lookup of a
> dictionary library:
>
> dictOid = get_ts_dict_oid(stringToQualifiedNameList("unaccent"),
> false);
>
yes, it risk, but similar is with timezones, and other external data.
Regards
Pavel
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + It's impossible for everything to be true. +
>
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2013-09-14 15:28:29 | Re: review: pgbench progress report improvements |
Previous Message | Andres Freund | 2013-09-14 13:09:48 | Re: record identical operator |