Re: idea: log_statement_sample_rate - bottom limit for sampling

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Gilles Darold <gilles(at)darold(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: idea: log_statement_sample_rate - bottom limit for sampling
Date: 2019-06-17 20:40:56
Message-ID: CAFj8pRAVCaB601vRLOrjPc-MukiG1EdLuB2P4MUxqP-ZSFVjDg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

čt 6. 6. 2019 v 10:48 odesílatel Gilles Darold <gilles(at)darold(dot)net> napsal:

> Le 06/06/2019 à 10:38, Pavel Stehule a écrit :
> > Hi
> >
> > I like the idea of sampling slow statements via
> > log_statement_sample_rate. But I miss some parameter that can ensure
> > so every query executed over this limit is logged.
> >
> > Can we introduce new option
> >
> > log_statement_sampling_limit
> >
> > The query with execution time over this limit is logged every time.
> >
> > What do you think about this?
> >
> > Regards
> >
> > Pavel
>
>
> +1, log_min_duration_statement is modulated by log_statement_sample_rate
> that mean that there is no more way to log all statements over a certain
> duration limit. log_statement_sampling_limit might probably always be
> upper than log_min_duration_statement.
>

Here is a patch

Regards

Pavel

>
> --
> Gilles Darold
> http://www.darold.net/
>
>

Attachment Content-Type Size
log_statement_sample_limit.patch text/x-patch 4.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2019-06-17 20:57:19 Re: SQL/JSON path issues/questions
Previous Message Alexander Korotkov 2019-06-17 20:13:04 Re: SQL/JSON path issues/questions