From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Wrong usage of pqMsg_Close message code? |
Date: | 2023-08-28 11:38:57 |
Message-ID: | CAFj8pRAMDCJXjnwiCkCB1yO1f7NPggFY8PwwAJDnugu-Z2G-Cg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
I workin with protocol and reading related code.
I found in routine EndCommand one strange thing
void
EndCommand(const QueryCompletion *qc, CommandDest dest, bool
force_undecorated_output)
{
<-->char<--><-->completionTag[COMPLETION_TAG_BUFSIZE];
<-->Size<--><-->len;
<-->switch (dest)
<-->{
<--><-->case DestRemote:
<--><-->case DestRemoteExecute:
<--><-->case DestRemoteSimple:
<--><--><-->len = BuildQueryCompletionString(completionTag, qc,
<--><--><--><--><--><--><--><--><--><--><--> force_undecorated_output);
<--><--><-->pq_putmessage(PqMsg_Close, completionTag, len + 1);
<--><-->case DestNone:
There is message PqMsgClose, but this should be used from client side. Here
should be used PqMsg_CommandComplete instead?
Regards
Pavel
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2023-08-28 11:48:05 | Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment |
Previous Message | Alvaro Herrera | 2023-08-28 11:36:00 | Re: Strange presentaion related to inheritance in \d+ |