Re: Remove "Source Code" column from \df+ ?

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Masao Fujii <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: Remove "Source Code" column from \df+ ?
Date: 2016-10-12 03:52:19
Message-ID: CAFj8pRAKD+1V8dUPK_bz4k-HevjY+TTyvQFas+QmaFpjUr4oJg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2016-10-12 1:51 GMT+02:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > As was mentioned, this thread doesn't really need a patch but rather
> > some comment from those who have voiced a -1 on removing the PL source
> > code column.
>
> > In another, perhaps vain, attempt to get to a consensus, here's what it
> > looks like the current standings are for "Remove source from \df+",
>
> I think this is oversimplified, because there are multiple proposals on
> the table, and it's not entirely clear to me who approves of which.
> We have at least the following options:
>
> 1. Do nothing.
> 2. Remove the prosrc column from \df+ altogether.
> 3. Suppress prosrc for PL functions, but continue to show it for
> C and internal functions (and, probably, rename it to something
> other than "Source code" in that case).
> 4. #3 plus show PL function source code in footers.
>
> Personally I like #4 better than #3 better than #2 better than #1,
> but the only one I'm really against is "do nothing".
>

My preferences: #2, #1 - I dislike #4 more than #1 - I don't see any
benefit there

Regards

Pavel

>
> > There have been a number of voices asking that we do *something* here.
>
> Yes. I agree with your summary that Peter is the only one who appears
> to be in favor of "do nothing" (and even there, his complaint was at
> least partly procedural not substantive).
>
> regards, tom lane
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2016-10-12 03:55:59 Re: autonomous transactions
Previous Message Haribabu Kommi 2016-10-12 03:21:25 Re: New SQL counter statistics view (pg_stat_sql)