Re: custom function for converting human readable sizes to bytes

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: custom function for converting human readable sizes to bytes
Date: 2015-12-22 09:45:30
Message-ID: CAFj8pRAFC9i7QKDUVqcA8y7=ceW0LcAugR6O=r2aSn6CBhWXpw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

2015-12-21 16:11 GMT+01:00 Robert Haas <robertmhaas(at)gmail(dot)com>:

> On Sun, Dec 20, 2015 at 4:54 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> > new update:
> >
> > 1. unit searching is case insensitive
> >
> > 2. initial support for binary byte prefixes - KiB, MiB, .. (IEC
> standard),
> > change behave for SI units
> >
> > Second point is much more complex then it is looking - if pg_size_bytes
> > should be consistent with pg_size_pretty.
> >
> > The current pg_size_pretty and transformations in guc.c are based on
> JEDEC
> > standard. Using this standard for GUC has sense - using it for object
> sizes
> > is probably unhappy.
> >
> > I tried to fix (and enhance) pg_size_pretty - now reports correct units,
> and
> > via second parameter it allows to specify base: 2 (binary, IEC -
> default)
> > or 10 (SI).
>
> -1 from me. I don't think we should muck with the way pg_size_pretty
> works.
>

new update - I reverted changes in pg_size_pretty

Regards

Pavel

>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
pg-size-bytes-04.patch text/x-patch 15.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2015-12-22 09:55:52 Re: pglogical_output - a general purpose logical decoding output plugin
Previous Message Kyotaro HORIGUCHI 2015-12-22 09:44:02 Re: Some bugs in psql_complete of psql