Re: IF (NOT) EXISTS in psql-completion

2017-01-31 11:10 GMT+01:00 Kyotaro HORIGUCHI <
horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>:

> At Tue, 31 Jan 2017 15:07:55 +0900, Michael Paquier <
> michael(dot)paquier(at)gmail(dot)com> wrote in <CAB7nPqTCuK1qVQNwPvnxhA9trxp22
> 8v0X6A4gKQb2Uc=mc+adQ(at)mail(dot)gmail(dot)com>
> > On Tue, Jan 31, 2017 at 2:58 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> > > I found a error - I sent mail only to author 2016-12-31 :( - It is my
> > > mistake. I am sorry
> >
> > Ah... Thanks for the update. No problem.
>
> Ouch. Sorry for missing you commnet. I'll dig my mail box for that.
>

I am doing a review of this set of patches:

1. There are no problem with patching, compiling - all regress tests passed

2. tab complete doesn't work well if I am manually writing "create index
on" - second "ON" is appended - it is a regression

I didn't find any other issues -

note: not necessary to implement (nice to have) - I miss a support for OR
REPLACE flag - it is related to LANGUAGE, TRANSFORMATION, FUNCTION and
RULE.

Regards

>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center
>
>
>