Re: WIP Patch for GROUPING SETS phase 1

2014-08-21 17:00 GMT+02:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> > "Heikki" == Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> > Heikki> I think we should bite the bullet and rename the extension,
>
> > I agree, the contrib/cube patch as posted is purely so we could test
> > everything without having to argue over the new name first.
>
> I wonder if you've tried hard enough to avoid reserving the keyword.
>
> I think that the cube extension is not going to be the only casualty
> if "cube" becomes a reserved word --- that seems like a name that
> could be in use in lots of applications. ("What do you mean, 9.5
> breaks our database for tracking office space?") It would be worth
> quite a bit of effort to avoid that.
>

My prototypes worked without reserved keywords if I remember well

but analyzer is relatively complex

Pavel

>
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>