| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Transform for pl/perl |
| Date: | 2017-11-15 08:09:58 |
| Message-ID: | CAFj8pRA0ZhFH_G8Z_xagygbdZYbmX0NE74tTQd+=qD0=XDZYgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
> Hello,
> Thank you for your review. I have fixed most of your comments, except
> for the 5-th part, about data::dumper - I just couldn't understand
> your point, but I've added more tests with more complex objects if this
> helps.
>
> Please, take a look at new patch. You can find it in attachments to
> this message (it is called "0001-jsonb_plperl-extension-v2.patch")
>
I changed few lines in regress tests.
Now, I am think so this patch is ready for commiters.
1. all tests passed
2. there are some basic documentation
I have not any other objections
Regards
Pavel
> --
> Anthony Bykov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-jsonb_plperl-extension-v3.patch | text/x-patch | 31.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 高增琦 | 2017-11-15 08:10:18 | no library dependency in Makefile? |
| Previous Message | Michael Paquier | 2017-11-15 08:08:42 | Re: [HACKERS] [PATCH] Add recovery_min_apply_delay_reconnect recovery option |