| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, dinesh kumar <dineshkumar02(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: multiple psql option -c |
| Date: | 2015-10-31 18:50:17 |
| Message-ID: | CAFj8pRA-wahoCmL0qFFT=jrUj9AhAuG8F8Lbvs-4oBwK=5goHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
2015-09-21 16:46 GMT+02:00 Adam Brightwell <
adam(dot)brightwell(at)crunchydatasolutions(dot)com>:
> Pavel,
>
> > with -1 option support
>
> FWIW, I have tried to apply this patch against master (7f11724) and
> there is a minor error, see below.
>
> From patch:
>
> patching file src/bin/psql/settings.h
> Hunk #2 FAILED at 135.
> 1 out of 2 hunks FAILED -- saving rejects to file
> src/bin/psql/settings.h.rej
>
> From settings.h.rej:
>
> --- src/bin/psql/settings.h
> +++ src/bin/psql/settings.h
> @@ -135,6 +141,7 @@
> const char *prompt2;
> const char *prompt3;
> PGVerbosity verbosity; /* current error verbosity level */
> + GroupCommand *group_commands;
> } PsqlSettings;
>
> extern PsqlSettings pset;
>
yes, it was broken by context visibility patch.
fixed patch attached
Regards
Pavel
>
> -Adam
>
> --
> Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
> Database Engineer - www.crunchydatasolutions.com
>
| Attachment | Content-Type | Size |
|---|---|---|
| psql-group-command-03.patch | text/x-patch | 10.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-10-31 19:42:08 | Minor clarifying changes to abbreviated key abort code comments |
| Previous Message | Julien Rouhaud | 2015-10-31 18:25:06 | Re: [BUGS] BUG #12989: pg_size_pretty with negative values |