Re: WITHIN GROUP patch

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WITHIN GROUP patch
Date: 2013-10-11 06:35:23
Message-ID: CAFj8pRA=-RDzVFN8nzR0F+u5HmiMHksk9J1HdnVmETCPVEn=yQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2013/10/11 Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>

> >>>>> "Pavel" == Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
>
> >> I found so following error message is not too friendly (mainly because
> >> this functionality will be new)
> >>
> >> postgres=# select dense_rank(3,3,2) within group (order by num desc,
> odd)
> >> from test4;
> >> ERROR: Incorrect number of arguments for hypothetical set function
> >> LINE 1: select dense_rank(3,3,2) within group (order by num desc, od...
> >> ^
> >>
> >> Probably some hint should be there?
>
> Hm, yeah.
>
> Anyone have ideas for better wording for the original error message,
> or a DETAIL or HINT addition? The key point here is that the number of
> _hypothetical_ arguments and the number of ordered columns must match,
> but we don't currently exclude the possibility that a user-defined
> hypothetical set function might have additional non-hypothetical args.
>
> The first alternative that springs to mind is:
>
> ERROR: Incorrect number of arguments for hypothetical set function
> DETAIL: Number of hypothetical arguments (3) must equal number of ordered
> columns (2)
>
> +1

Pavel

> --
> Andrew (irc:RhodiumToad)
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu kommi 2013-10-11 07:09:39 Re: Compression of full-page-writes
Previous Message Josh Berkus 2013-10-11 05:20:36 Re: Auto-tuning work_mem and maintenance_work_mem