Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher
Date: 2020-07-15 12:51:20
Message-ID: CAFiTN-vry=fv7fHSnEOFPu6feH_1KTXcTkYEMb-t1HOgaPw_1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 15, 2020 at 6:17 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> In ApplyLauncherMain, it seems like we are having SIGTERM signal
> mapped for config reload. I think we should be having SIGHUP for
> SignalHandlerForConfigReload(). Otherwise we miss to take the updated
> value for wal_retrieve_retry_interval in ApplyLauncherMain.
>
> Attached is a patch having this change.
>
> Thoughts?

Yeah, it just looks like a typo so your fix looks good to me.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2020-07-15 12:54:37 Which SET TYPE don't actually require a rewrite
Previous Message Bharath Rupireddy 2020-07-15 12:46:43 Have SIGHUP instead of SIGTERM for config reload in logical replication launcher