| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Questions/Observations related to Gist vacuum |
| Date: | 2020-01-13 03:25:57 |
| Message-ID: | CAFiTN-vXVG3gthLWy0RNBcdXhBkb7FS91qktAsPJr00UyGwE9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 9, 2020 at 4:41 PM Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> wrote:
>
> On Mon, 9 Dec 2019 at 14:37, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > I have modified the patch for the above points and additionally ran
> > > pgindent. Let me know what you think about the attached patch?
> > >
> >
> > A new version with a slightly modified commit message.
>
> I reviewed v4 patch and below is the one review comment:
>
> + * These are used to memorize all internal and empty leaf pages. They are
> + * used for deleting all the empty pages.
> */
> After dot, there should be 2 spaces. Earlier, there was 2 spaces.
>
> Other than that patch looks fine to me.
>
Thanks for the comment. Amit has already taken care of this before pushing it.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-01-13 03:50:27 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Justin Pryzby | 2020-01-13 01:47:53 | Re: bitmaps and correlation |