| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Identify missing publications from publisher while create/alter subscription. |
| Date: | 2021-05-03 05:18:53 |
| Message-ID: | CAFiTN-vB-yy7G1ZtRKSkMpZf8xNN9mP_rxjiOojmni4CtvGAWg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 2, 2021 at 10:04 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the comments.
> The Attached patch has the fixes for the same.
I was reviewing the documentation part, I think in the below paragraph
we should include validate_publication as well?
<varlistentry>
<term><literal>connect</literal> (<type>boolean</type>)</term>
<listitem>
<para>
Specifies whether the <command>CREATE SUBSCRIPTION</command>
should connect to the publisher at all. Setting this to
<literal>false</literal> will change default values of
<literal>enabled</literal>, <literal>create_slot</literal> and
<literal>copy_data</literal> to <literal>false</literal>.
</para>
I will review/test the other parts of the patch and let you know.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-05-03 05:26:51 | Re: Replication slot stats misgivings |
| Previous Message | Bharath Rupireddy | 2021-05-03 05:12:29 | Logical Replication - behavior of TRUNCATE ... CASCADE |