| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUG] "FailedAssertion" reported when streaming in logical replication |
| Date: | 2021-04-30 04:38:04 |
| Message-ID: | CAFiTN-v9vk-q9jfU1g396b=CdJOzm3gy=912dmF4xXF_DsH36w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 29, 2021 at 5:24 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Apr 27, 2021 at 5:18 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > I have modified the patch based on the above comments.
> >
>
> The patch looks good to me. I have slightly modified the comments and
> commit message. See, what you think of the attached? I think we can
> leave the test for this as there doesn't seem to be an easy way to
> automate it.
Your changes look good to me.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-04-30 04:47:00 | Re: Enhanced error message to include hint messages for redundant options error |
| Previous Message | David Rowley | 2021-04-30 03:38:10 | Re: Use simplehash.h instead of dynahash in SMgr |