| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |
| Date: | 2023-11-24 09:07:33 |
| Message-ID: | CAFiTN-udSTGG_t5n9Z3eBbb4_=zNoKU+8FP-S6zpv-r4Gm-Y+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 24, 2023 at 10:17 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Thu, Nov 23, 2023 at 11:34 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > Note: With this testing, we have found a bug in the bank-wise
> > approach, basically we are clearing a procglobal->clogGroupFirst, even
> > before acquiring the bank lock that means in most of the cases there
> > will be a single process in each group as a group leader
>
> I realized that the bug fix I have done is not proper, so will send
> the updated patch set with the proper fix soon.
PFA, updated patch set fixes the bug found during the testing of the
group update using the injection point. Also attached a path to test
the injection point but for that, we need to apply the injection point
patches [1]
[1] https://www.postgresql.org/message-id/ZWACtHPetBFIvP61%40paquier.xyz
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0002-Divide-SLRU-buffers-into-banks.patch | application/octet-stream | 13.7 KB |
| v8-0001-Make-all-SLRU-buffer-sizes-configurable.patch | application/octet-stream | 24.0 KB |
| v8-0003-Remove-the-centralized-control-lock-and-LRU-count.patch | application/octet-stream | 74.0 KB |
| test_group_commit.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-11-24 09:16:41 | Re: Synchronizing slots from primary to standby |
| Previous Message | jian he | 2023-11-24 08:41:45 | Re: remaining sql/json patches |