Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager
Date: 2020-03-15 15:54:31
Message-ID: CAFiTN-uYu3Aw+keuag3oUD788pCY7VMDzxQuOXiveF4yU84MDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 15, 2020 at 6:20 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sun, Mar 15, 2020 at 4:34 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > I have modified 0001 and 0002 slightly, Basically, instead of two
> > function CheckAndSetLockHeld and CheckAndReSetLockHeld, I have created
> > a one function.
> >
>
> +CheckAndSetLockHeld(LOCALLOCK *locallock, bool value)
>
> Can we rename the parameter as lock_held, acquired or something like
> that so that it indicates what it intends to do and probably add a
> comment for that variable atop of function?

Done

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v9-0002-Add-assert-to-ensure-that-page-locks-don-t-partic.patch application/octet-stream 3.0 KB
v9-0003-Allow-relation-extension-lock-to-conflict-among-p.patch application/octet-stream 3.9 KB
v9-0001-Assert-that-we-don-t-acquire-a-heavyweight-lock-o.patch application/octet-stream 4.3 KB
v9-0004-Allow-page-lock-to-conflict-among-parallel-group-.patch application/octet-stream 9.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-15 16:48:09 Re: proposal: new polymorphic types - commontype and commontypearray
Previous Message Dilip Kumar 2020-03-15 15:47:40 Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager