Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

On Mon, Dec 13, 2021 at 8:34 AM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>
> + /*
> + * If the relation is from the default tablespace then we need to
> + * create it in the destinations db's default tablespace. Otherwise,
> + * we need to create in the same tablespace as it is in the source
> + * database.
> + */
>
> This comment looks a bit confusing to me especially because when we say destination db's default tablespace people may think of pg_default tablespace (at least I think so). Basically what you are trying to say here - "If the relation exists in the same tablespace as the src database, then in the destination db also it should be the same or something like that.. " So, why not put it that way instead of referring to it as the default tablespace. It's just my view. If you disagree you can ignore it.
>
> --
>
> + else if (src_dboid == dst_dboid)
> + continue;
> + else
> + dstrnode.spcNode = srcrnode.spcNode;;
>
> There is an extra semicolon here.

Noted. I will fix them in the next version.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com