| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: Decoding speculative insert with toast leaks memory |
| Date: | 2021-06-09 13:46:39 |
| Message-ID: | CAFiTN-uCAt19gxuabMuXZ=gw+vx4YAGVE5-5OS77kTLSeX_8XA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 9, 2021 at 4:22 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Jun 9, 2021 at 4:12 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >> Few comments:
> >> 1. The test has a lot of similarities and test duplication with what
> >> we are doing in insert-conflict-specconflict.spec. Can we move it to
> >> insert-conflict-specconflict.spec? I understand that having it in
> >> test_decoding has the advantage that we can have all decoding tests in
> >> one place but OTOH, we can avoid a lot of test-code duplication if we
> >> add it in insert-conflict-specconflict.spec.
> >>
> >
> > It seems the isolation test runs on the default configuration, will it
> be a good idea to change the wal_level to logical for the whole isolation
> tester folder?
> >
>
> No, that doesn't sound like a good idea to me. Let's keep it in
> test_decoding then.
>
>
Okay, I will work on the remaining comments and back patches and send it by
tomorrow.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2021-06-09 13:48:00 | Re: DELETE CASCADE |
| Previous Message | Alvaro Herrera | 2021-06-09 13:31:24 | Re: Adjust pg_regress output for new long test names |