Re: Small issues with CREATE TABLE COMPRESSION

On Sat, May 8, 2021 at 6:43 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sat, May 08, 2021 at 05:37:58PM +0900, Michael Paquier wrote:
> > Thanks! I can dive into that if that's an issue. Let's make things
> > compatible with what upstream provides, meaning that we should have
> > some documentation pointing to the location of their deliverables,
> > equally to what we do for the Perl and OpenSSL dependencies for
> > example.
>
> Dilip has sent me a patch set without adding pgsql-hackers in CC (I
> guess these will be available soon).

My bad.

Anyway, this patch included a
> change to fix a hole in the installation docs, where --with-lz4 is not
> listed yet. I have reviewed that stuff and found more
> inconsistencies in the docs, leading me to the attached:
> - The upstream project name is "LZ4", so we had better use the correct
> name when not referring to the option value used in CREATE/ALTER
> TABLE.
> - doc/src/sgml/installation.sgml misses a description for --with-lz4.
>
> Without the Windows changes, I am finishing with the attached to close
> the loop with the docs.

Thanks for the changes. I will send the other patches soon, after
removing the doc part which you have already included here.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com