| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New SQL counter statistics view (pg_stat_sql) |
| Date: | 2017-01-11 14:17:35 |
| Message-ID: | CAFiTN-txT6uNVb4LBN3md+CaxdLiLUvvunPErDocx6F7TWRo6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 5, 2016 at 8:01 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> Moved to next CF with "needs review" status.
I have started reviewing the patch, Some initial comments.
$ git apply ../pg_stat_sql_row_mode_2.patch
error: patch failed: src/include/catalog/pg_proc.h:2893
error: src/include/catalog/pg_proc.h: patch does not apply
Patch is not applying on the head, I think it needs to be rebased.
+void
+pgstat_count_sqlstmt(const char *commandTag)
+{
+ PgStat_SqlstmtEntry *htabent;
+ bool found;
+
+ if (!pgstat_track_sql)
+ return
Callers of pgstat_count_sqlstmt are always ensuring that
pgstat_track_sql is true, seems it's redundant here.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-01-11 14:21:35 | Re: pageinspect: Hash index support |
| Previous Message | Ashutosh Sharma | 2017-01-11 14:13:37 | Re: pageinspect: Hash index support |