| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUG]Update Toast data failure in logical replication |
| Date: | 2021-06-02 06:44:23 |
| Message-ID: | CAFiTN-tJqa3J_s-fSoJEzk55_UGXmU9+8AOBypveiQM_qAwsGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 1, 2021 at 3:39 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Tue, Jun 1, 2021 at 12:29 PM tanghy(dot)fnst(at)fujitsu(dot)com
> > I noticed that in case1, ExtractReplicaIdentity function returned NULL on HEAD. But after your fix, it didn’t return NULL. There is no problem with this case on HEAD, but the patch modified its return value. I’m not sure if it would bring new problems. Have you checked it?
>
> Good observation, basically, my check says that any field in the tuple
> is toasted then prepare the key tuple, actually, after that, I should
> recheck whether the key field specifically toasted or not and if it is
> not then we can continue returning NULL. I will fix this in the next
> version.
Attached patch fixes that, I haven't yet added the test case. Once
someone confirms on the approach then I will add a test case to the
patch.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Extract-unchanged-replica-identity-key-if-it-is-s.patch | text/x-patch | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-06-02 06:44:59 | Re: security_definer_search_path GUC |
| Previous Message | Amit Kapila | 2021-06-02 06:22:52 | Re: Decoding speculative insert with toast leaks memory |