Re: Support reset of Shared objects statistics in "pg_stat_reset" function

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Cc: Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>, Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support reset of Shared objects statistics in "pg_stat_reset" function
Date: 2021-08-11 03:47:16
Message-ID: CAFiTN-tFvydpjKuk5ue5hppQnB-GT+3eE6R5cUt8_oGwNpiT5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 10, 2021 at 10:49 PM Mahendra Singh Thalor
<mahi6run(at)gmail(dot)com> wrote:

> I checked this and found that we already have one process "stats
> collector" and in v02 patch, we are sending requests to collect stats
> two times. I don't know how costly one call is but I feel that we can
> avoid the 2nd call by keeping handling of the shared tables into
> pgstat_recv_resetcounter.
>

I think let's not make the stat collector aware of what we want to
achieve, so the stat collector will only reset for what we have asked
for and let the caller or the signal sender decide what they want to
do.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2021-08-11 04:29:49 Re: use-regular-expressions-to-simplify-less_greater-and-not_equals.patch
Previous Message Tom Lane 2021-08-11 03:36:15 Re: use-regular-expressions-to-simplify-less_greater-and-not_equals.patch