Re: Make relfile tombstone files conditional on WAL level

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make relfile tombstone files conditional on WAL level
Date: 2022-05-16 10:57:28
Message-ID: CAFiTN-spe6WtSm1Ovn8wEc8JX9e3YFtqeHwA4DPMQQksH6PvZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 16, 2022 at 3:24 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> I think you can get rid of SYNC_UNLINK_REQUEST, sync_unlinkfiletag,
> mdunlinkfiletag as these are all now unused.

Correct.

> Are there any special hazards here if the plan in [1] goes ahead?

IMHO we should not have any problem. In fact, we need this for [1]
right? Otherwise, there is a risk of reusing the same relfilenode
within the same checkpoint cycle as discussed in [2].

> [1] https://www.postgresql.org/message-id/flat/CA%2BTgmoYmw%3D%3DTOJ6EzYb_vcjyS09NkzrVKSyBKUUyo1zBEaJASA%40mail.gmail.com

[2] https://www.postgresql.org/message-id/CA+TgmoZZDL_2E_zuahqpJ-WmkuxmUi8+g7=dLEny=18r-+c-iQ@mail.gmail.com

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-05-16 12:19:28 Re: Remove support for Visual Studio 2013
Previous Message Michael Paquier 2022-05-16 10:34:31 Re: Remove support for Visual Studio 2013