| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Date: | 2020-06-15 03:41:58 |
| Message-ID: | CAFiTN-sYkK1s=__yhQiVJwN9p0evtWH6b9YVa7yAn=kqxE2HVg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 12, 2020 at 4:35 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jun 12, 2020 at 11:38 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > - Currently, while reading/writing the streaming/subxact files we are
> > reporting the wait event for example
> > 'pgstat_report_wait_start(WAIT_EVENT_LOGICAL_SUBXACT_WRITE);', but
> > BufFileWrite/BufFileRead internally reports the read/write wait event.
> > So I think we can avoid reporting that?
> >
>
> Yes, we can avoid that. No other place using BufFileRead does any
> such reporting.
I agree.
> > Basically, this part is still
> > I have to work upon, once we get the consensus then I can remove those
> > extra wait event from the patch.
> >
>
> Okay, feel free to send an updated patch with the above change.
Sure, I will do that in the next patch set.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Wong | 2020-06-15 03:45:17 | Re: doc examples for pghandler |
| Previous Message | Fujii Masao | 2020-06-15 03:40:03 | min_safe_lsn column in pg_replication_slots view |