Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

On Tue, Mar 1, 2022 at 5:15 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:

> On Tue, Feb 22, 2022 at 8:27 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
> wrote:
>
>> I'm not sure about the current status, but found it while playing
>> around with the latest changes a bit, so thought of sharing it here.
>>
>> + <varlistentry>
>> + <term><replaceable class="parameter">strategy</replaceable></term>
>> + <listitem>
>> + <para>
>> + This is used for copying the database directory. Currently, we
>> have
>> + two strategies the <literal>WAL_LOG_BLOCK</literal> and the
>>
>> Isn't it wal_log instead of wal_log_block?
>>
>> I think when users input wrong strategy with createdb command, we
>> should provide a hint message showing allowed values for strategy
>> types along with an error message. This will be helpful for the users.
>>
>
> I will fix these two comments while posting the next version.
>
>

The new version of the patch fixes these 2 comments pointed by Ashutosh and
also splits the GetRelListFromPage() function as suggested by Robert and
uses the latest snapshot for scanning the pg_class instead of active
snapshot as pointed out by Robert. I haven't yet added the test case to
create a database using this new strategy option. So if we are okay with
these two options FILE_COPY and WAL_LOG then I will add test cases for the
same.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com