| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Move pg_attribute.attcompression to earlier in struct for reduced size? |
| Date: | 2021-05-25 06:15:27 |
| Message-ID: | CAFiTN-sDLtGeK3HpH4XPZEOwZOQ7xPJMvJeuSdZJfo_WHOz0Cw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 25 May 2021 at 11:16 AM, Michael Paquier <michael(at)paquier(dot)xyz>
wrote:
> On Mon, May 24, 2021 at 02:46:11PM +0530, Dilip Kumar wrote:
> > Like this.
> > if (TupleDescAttr(newTupDesc, i)->attisdropped)
> > isnull[i] = true;
> > else
> > tup_values[i] = values[i];
>
> That would work. Your suggestion, as I understood it first, makes the
> code simpler by not using tup_values at all as the set of values[] is
> filled when the values and nulls are extracted. So I have gone with
> this simplification, and applied the patch (moved a bit the comments
> while on it).
Perfect. That looks much better.
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-05-25 06:35:19 | Re: Different compression methods for FPI |
| Previous Message | Neil Chen | 2021-05-25 06:10:15 | Re: [PATCH] In psql \?, add [+] annotation where appropriate |