From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: XLogBeginRead's header comment lies |
Date: | 2022-08-17 06:01:45 |
Message-ID: | CAFiTN-sCGjU6fbspPmdjhikNbAWuPSS-Y62Ea7p8253c4wrbAw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 17, 2022 at 11:18 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Tue, Aug 16, 2022 at 11:28 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >
>
> Yeah I think it makes sense to make it work as per the comment in
> XLogBeginRecord(). I think if we modify the Assert as per the comment
> of XLogBeginRecord() then the remaining code of the
> XLogDecodeNextRecord() is capable enough to take care of skipping the
> page header if we are pointing at the beginning of the block.
>
> See attached patch.
>
I think that is not sufficient, if there is a record continuing from
the previous page and we are pointing to the start of the page then
this assertion is not sufficient. I think if the
targetRecOff is zero then we should additionally read the header and
verify that XLP_FIRST_IS_CONTRECORD is not set.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-08-17 06:02:28 | Re: Assertion failure on PG15 with modified test_shm_mq test |
Previous Message | Michael Paquier | 2022-08-17 06:00:20 | Re: Materialized view rewrite is broken when there is an event trigger |