Re: ON CONFLICT DO NOTHING on pg_dump

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Surafel Temesgen <surafel3000(at)gmail(dot)com>
Cc: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ON CONFLICT DO NOTHING on pg_dump
Date: 2018-06-16 08:36:55
Message-ID: CAFiTN-s2kNct+PbrwyKjXXVOyDFrFjjoFS+_DtWEOrF7rsWeXQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 14, 2018 at 4:09 PM, Surafel Temesgen <surafel3000(at)gmail(dot)com> wrote:
>
>
> thank you for pointing me that i add basic test and it seems to me the rest
> of the test is covered by column_inserts test

@@ -172,6 +172,7 @@ typedef struct _dumpOptions
char *outputSuperuser;

int sequence_data; /* dump sequence data even in schema-only mode */
+ int do_nothing;
} DumpOptions;

The new structure member appears out of place, can you move up along
with other "command-line long options" ?

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-06-16 09:38:59 Re: WAL prefetch
Previous Message Tatsuo Ishii 2018-06-16 05:44:20 Re: Memory leaks in BufFileOpenShared()