From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
---|---|
To: | Thom Brown <thom(at)linux(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Subject: | Re: [PATCH] Tables node (pgAdmin4) |
Date: | 2016-05-07 14:13:53 |
Message-ID: | CAFiP3vzDkX587zc0S_Dubf6v3Df0pBf5tcyzWefTrMYPaB=ogw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
i have fixed all of below mentioned issues.
> A couple more:
>
>
> If I go to create a new table, give it a name, select a table to
> inherit from, and then do nothing else, I get an error:
>
> ERROR: syntax error at or near "INHERITS"
> LINE 2: INHERITS (test)
> ^
>
> This is because no column list was provided, and in this case, an
> empty one would be needed. So instead of:
>
> CREATE TABLE public.test2
> (
> )
> INHERITS (test)
> WITH (
> OIDS = FALSE
> )
> TABLESPACE pg_default;
>
> It should be:
>
> CREATE TABLE public.test2
> INHERITS (test)
> WITH (
> OIDS = FALSE
> )
> TABLESPACE pg_default;
>
>
> If I go to create another new table, give it a name, and then in the
> Like section on the Advance tab, I select a table, and enable each of
> the With * options, the following SQL is produced:
>
> CREATE TABLE public.test2
> LIKE public.test
> INCLUDING DEFAULTS
> INCLUDING CONSTRAINTS
> INCLUDING INDEXES
> INCLUDING STORAGE
> INCLUDING COMMENTSWITH (
> OIDS = FALSE
> )
> TABLESPACE pg_default;
>
> The LIKE statement should appear in the column list section, so should
> be surrounded in parentheses. Also, the WITH statement here is not on
> a new line.
>
> So this should be:
>
> CREATE TABLE public.test2
> (
> LIKE public.test
> INCLUDING DEFAULTS
> INCLUDING CONSTRAINTS
> INCLUDING INDEXES
> INCLUDING STORAGE
> INCLUDING COMMENTS
> )
> WITH (
> OIDS = FALSE
> )
> TABLESPACE pg_default;
>
>
>
>
> Thom
>
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-05-07 14:15:34 | Re: [PATCH] Tables node (pgAdmin4) |
Previous Message | Harshal Dhumal | 2016-05-07 14:12:09 | Re: [PATCH] Tables node (pgAdmin4) |