Patch for RM1500 other issues [pgAdmin4]

From: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Patch for RM1500 other issues [pgAdmin4]
Date: 2016-08-03 06:36:43
Message-ID: CAFiP3vyQX28ZAbMB4cSnU3-o_s1O1VP6hdQjz6uq=oRFH-9scg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

PFA patch for RM1500.

Changes/Issues fixed:

1] datamodel.js: For collection type added check before adding model into
"changed" list instead of adding it blindly.

2] Type casting from str to int of column properties like attlen,
attpricision.

3] Added missing data formating when adding new column to existing table
(from table edit mode).

4] Added more validation for Foreign key constraint.

5] Column.js: Column grid (in table edit mode) show proper disabled color
for disabled cell when grid renders.

6] All constraints and index js added idattribute to distinguish which
s/constraint or s/index is updated on server side.

7] Column update.sql: Fixed sql when altering column data type. The issue
was when we alter data type from which has length and precision to data
type which don't have these properties and vice versa.
For e.g. alter data type numeric(10,12) to real (and vice versa)

8] Renaming constraint (RM1500).

--
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
RM1500.patch text/x-patch 38.2 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-08-03 09:15:46 Re: pgAdmin IV : Unittest modular patch
Previous Message Phill Pafford 2016-08-02 18:10:25 PGAdmin 4 Feature Request