From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix for RM1318 [pgadmin4] |
Date: | 2016-06-13 18:20:09 |
Message-ID: | CAFiP3vy6zuoQeZkjCci7jbuaouuz6U6t+V=47pRZJC-PhJAwSQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
PFA patch for issue RM1318 with remaining bug fixes.
On Mon, Jun 13, 2016 at 8:49 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal
> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA attached patch for issue RM1318.
> >
> >
> > Issue fixed: Added help buttons on backup, restore, maintenance, user
> > management dialogs.
>
> Thanks - I've committed this as-is, however the following issues
> should also be fixed:
>
> - The help for the User Manager dialogue cannot be used because the
> dialogue is modal.
>
Changed user dialog to non modal from modal dialog.
>
> - There's no help button on the Preferences dialogue. It should also
> be made non-modal so the user can actually use the help once it's
> displayed.
>
Added missing help button and also changed dialog to non modal.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
RM1318_V2.patch | text/x-patch | 3.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-06-13 18:37:44 | Fix for issue RM1348 [pgadmin4] |
Previous Message | Dave Page | 2016-06-13 16:17:03 | Re: pgadmin4 slow with large tables compared to pgadmin3 |