| From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: RM3079 fix for wrong sql datetime/time related datatypes |
| Date: | 2018-02-28 11:24:54 |
| Message-ID: | CAFiP3vxELyjKv3LRoLP66g_FPGA_ajdSA6Rai-vZmgUJwpCfrA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
On Tue, Feb 27, 2018 at 8:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find patch to fix wrong sql issue for time related type.
>>
>> Steps to reproduce:
>>
>> Alter any time/datetime array related data type, it generates sql with
>> addition array bracket
>>
>> [image: Inline image 1]
>>
>
> This seems to be missing the test case that you noted should be included
> in the original bug report!
>
Please find updated patch with test cases.
Thanks,
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM3079_V2.patch | text/x-patch | 13.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khushboo Vashi | 2018-02-28 11:49:19 | Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query |
| Previous Message | Murtuza Zabuawala | 2018-02-28 10:35:29 | Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI |