| From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Matthew Kleiman <mkleiman(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
| Subject: | Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling |
| Date: | 2017-07-21 11:34:26 |
| Message-ID: | CAFiP3vx=G19x+a2XQg4Ef4QheapXC5L0-pzkXBv69EaX72D=hw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Jul 21, 2017 4:23 PM, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:
On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> On Fri, Jul 21, 2017 at 2:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Currently if user clicks on empty white area below history entry then
>>> arrow navigation does not work.
>>> Attached patch fixes this issue.
>>>
>>
>> This fixes that problem, but stops it working if I *don't* click on the
>> white area first. We need both I think :-)
>>
> Yes we need both. Please find updated patch
>
Why all the changes to yarn.lock?
Are there? I can't see any changes.
Sent from my mobile
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-07-21 11:45:01 | pgAdmin 4 commit: Add a field to the Server Dialogue allowing users to |
| Previous Message | Murtuza Zabuawala | 2017-07-21 11:09:14 | Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor |