[RM2522] Improve grid/column select all operation

From: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [RM2522] Improve grid/column select all operation
Date: 2017-06-29 11:03:26
Message-ID: CAFiP3vwzh6SxGZ4sacg4c8o=RsDH-9-OC=_eYRaeu8R+9Ni-AA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find attached patch for RM2522.

With this patch grid/column select all time is reduce to ~1 second from
8-10 seconds.

The solution was to use simple array concatenation instead of underscore
union while getting index of all selected complete rows.
Underscore union function is only useful when user selects different ranges
from grid and those ranges overlaps. In this case union function removes
duplicate (overlapped) rows.
However result grid in sqleditor do not support overlapped row selection so
we can simply cancat rows from different ranges without worrying about
overlapped row selection.

--
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
RM2522_fix_performance_issue_with_grid_or_column_select_all.patch text/x-patch 655 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2017-06-29 11:09:32 Re: [RM2522] Improve grid/column select all operation
Previous Message Dave Page 2017-06-29 08:50:37 Re: Tree view icon samples