From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid |
Date: | 2017-07-18 13:40:53 |
Message-ID: | CAFiP3vweU--jRfUfHYM118GqanVOHEjXE1TqOa_CcwdRc60aJg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
On Tue, Jul 18, 2017 at 1:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>>
>> On Mon, Jul 17, 2017 at 9:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal <
>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find updated patch. Now placeholder string for bytea and bytea[]
>>>> data will only appear in datagrid (view all/1000/500 rows). If user
>>>> executes query using Query tool then placeholder won't appear (similar to
>>>> pgAdminIII behaviour)
>>>>
>>>
>>> I'm getting the following error when testing this:
>>>
>>
>> I ran all feature test cases 5-6 times and each time they ran
>> successfully.
>> May be this is occasional failure which we get after running test cases
>> for many times.
>>
>> Please let me know if you are getting this failure consistently at your
>> end.
>>
>
> I ran it twice and it failed twice. I can't keep running tests over and
> over again as they take quite a while to run and I can't use my machine for
> anything else at the same time as occasionally the test browser will grab
> focus.
>
Please find updated patch.
I have slightly modified feature test case for 'view data dml queries'
(though I wasn't getting failure as mentioned).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
RM2074_V3.patch | text/x-patch | 7.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Joao De Almeida Pereira | 2017-07-18 13:45:35 | Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website |
Previous Message | Shirley Wang | 2017-07-18 13:22:16 | Re: Testing out font changes in query editor tool |