Re: Missing newlines in verbose logs of pg_dump, introduced by RLS patch

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing newlines in verbose logs of pg_dump, introduced by RLS patch
Date: 2014-09-29 01:07:11
Message-ID: CAFcNs+rGyY7xuQzHTdjP2nk=BkaCA2gtgtV7vv94B6GkEAq0Hw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 28, 2014 at 1:36 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> Hi all,
>
> Recent commit 491c029 introducing RLS has broken a bit the verbose logs
of pg_dump, one message missing a newline:
> + if (g_verbose)
> + write_msg(NULL, "reading row-security enabled for
table \"%s\"",
> + tbinfo->dobj.name);
> The patch attached corrects that.
>

The schema name is missing... attached patch add it.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

Attachment Content-Type Size
pgdump_verbose_msg_fix_v1.patch text/x-diff 1022 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Flower 2014-09-29 01:15:34 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}
Previous Message Gregory Smith 2014-09-29 00:32:30 Re: Time measurement format - more human readable