From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Verbose output of pg_dump not show schema name |
Date: | 2014-07-23 21:48:23 |
Message-ID: | CAFcNs+qNHVcKQYbg-iGZe1e52oZ6sLm5QenRJs948qdyj9Hgfw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Apr 17, 2014 at 9:15 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> On Fri, Apr 18, 2014 at 4:29 AM, Fabrízio de Royes Mello
> <fabriziomello(at)gmail(dot)com> wrote:
> >
> > On Thu, Apr 17, 2014 at 12:46 PM, Bruce Momjian <bruce(at)momjian(dot)us>
wrote:
> >>
> >> On Thu, Apr 17, 2014 at 11:44:37AM -0400, Tom Lane wrote:
> >> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >> > > The idea is that we only need quotes when there are odd characters
in
> >> > > the identifier. We do that right now in some places, though I
can't
> >> > > find them in pg_dump. I know psql does that, see quote_ident().
> >> >
> >> > I think our general style rule is that identifiers embedded in
messages
> >> > are always double-quoted. There's an exception for type names, but
> >> > not otherwise. You're confusing the message case with printing SQL.
> >>
> >> OK. I was unclear if a status _display_ was a message like an error
> >> message.
> >>
> >
> > The attached patch fix missing double-quoted in "dumping contents of
> > table.." message and add schema name to other messages:
> > - "reading indexes for table \"%s\".\"%s\"\n"
> > - "reading foreign key constraints for table \"%s\".\"%s\"\n"
> > - "reading triggers for table \"%s\".\"%s\"\n"
> >
> > - "finding the columns and types of table \"%s\".\"%s\"\n"
> > - "finding default expressions of table \"%s\".\"%s\"\n"
> > - "finding check constraints for table \"%s\".\"%s\"\n"
> Cool additions. There may be a more elegant way to check if namespace
> is NULL, but I couldn't come up with one myself. So patch may be fine.
>
Hi all,
I think this small patch was lost. There are something wrong?
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2014-07-23 21:51:14 | Re: Making joins involving ctid work for the benefit of UPSERT |
Previous Message | Fabrízio de Royes Mello | 2014-07-23 20:48:27 | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |