From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
---|---|
To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, David Johnston <polobo(at)yahoo(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: trailing comment ghost-timing |
Date: | 2013-12-24 10:40:35 |
Message-ID: | CAFcNs+pkCAzhxJw63Chf2ni6ma89WevBEj3xzuR_QcWaZDNpdg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Dec 24, 2013 at 5:53 AM, Martijn van Oosterhout <kleptog(at)svana(dot)org>
wrote:
>
> On Tue, Dec 24, 2013 at 03:40:58AM +0100, Andreas Karlsson wrote:
> > On 12/24/2013 03:17 AM, David Johnston wrote:
> > It is not sent to the server as a trailing comment. The following
> > file is sent to the server like this.
> >
> > File:
> > /**/;
> > /**/
> >
> > Commands:
> > PQexec(..., "/**/;");
> > PQexec(..., "/**/");
> >
> > If this has to be fixed it should be in the client. I think people
> > would complain if we broke the API by starting to throw an exception
> > on PQexec with a string containing no actual query.
>
> (Untested). Isn't this just a case of psql not printing out a timing if
> the server responds with PGRES_EMPTY_QUERY?
>
Works... look to the attached patch!
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
Attachment | Content-Type | Size |
---|---|---|
psql-trailing-comment-ghost-timing-v1.patch | text/x-diff | 541 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2013-12-24 10:46:22 | Re: varattno remapping |
Previous Message | Martijn van Oosterhout | 2013-12-24 07:53:01 | Re: trailing comment ghost-timing |