Re: Sequence Access Method WIP

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sequence Access Method WIP
Date: 2016-04-05 17:54:32
Message-ID: CAFcNs+peRxMhWGvfQhCbcJy8b78Q7mj1bLKesgkjFcXNJfdFQA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 5, 2016 at 12:52 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>
>> I have just one question about de 0002 patch:
>> - There are some reason to not use TransactionId instead of uint32 in
>> GaplessSequenceState struct?
>>
>
> I missed we have that :)
>

Attached fix it and also I changed to use TransactionIdEquals instead of
compare xids directly.

- if (seqstate->xid != local_xid)
+ if (!TransactionIdEquals(seqstate->xid, local_xid))

IMHO this patch is Ready for Commiter. Changed status in CommitfestApp.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

Attachment Content-Type Size
0001-seqam-2016-04-05.patch text/x-diff 168.4 KB
0002-gapless-seq-2016-04-05.patch text/x-diff 27.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robbie Harwood 2016-04-05 17:58:52 Re: [PATCH v12] GSSAPI encryption support
Previous Message Abhijit Menon-Sen 2016-04-05 17:43:58 Re: dealing with extension dependencies that aren't quite 'e'